Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create functionality to navigate from a route in one package to a route in another package #11447

Closed
ghost opened this issue Oct 26, 2023 · 2 comments · Fixed by #11883
Closed
Labels
added-to-sprint kind/user-story Used for issues that describes functionality for our users. quality/code Violations from current rules for code, best practices, etc. Or just bad code. status/draft Status: When you create an issue before you have enough info to properly describe the issue.

Comments

@ghost
Copy link

ghost commented Oct 26, 2023

Description

Right now, the only way to navigate from anywhere in app-development to dashboard is to use window.location.assign('/');.
This should be refactored to its own function so that we are able to easily navigate between the packages.

Additional Information

No response

Tasks

No response

Acceptance Criterias

No response

@ghost ghost added kind/user-story Used for issues that describes functionality for our users. status/draft Status: When you create an issue before you have enough info to properly describe the issue. labels Oct 26, 2023
@framitdavid
Copy link
Collaborator

framitdavid commented Oct 26, 2023

I agree! To abstract the navigating between packages (multiple React Routers) would be nice for two things. We will have a utility method which handles the cross-package navigation and as developers, we do not care about implementation details such as a window.location.assign().

Another benefit is that we can abstract the routes as well, meaning that the packages do not need to know the routes from another package.

interface:
navigateToPackage: (packageName: string) => void

usage:
navigateToPackage('dashboard');

@nkylstad nkylstad added the quality/code Violations from current rules for code, best practices, etc. Or just bad code. label Nov 3, 2023
@ghost ghost added the added-to-sprint label Dec 18, 2023
@ghost ghost self-assigned this Dec 18, 2023
@ghost ghost linked a pull request Dec 18, 2023 that will close this issue
3 tasks
@ghost ghost removed their assignment Dec 18, 2023
@ghost ghost closed this as completed in #11883 Dec 19, 2023
@framitdavid
Copy link
Collaborator

Tested OK in dev

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint kind/user-story Used for issues that describes functionality for our users. quality/code Violations from current rules for code, best practices, etc. Or just bad code. status/draft Status: When you create an issue before you have enough info to properly describe the issue.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants