-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full configuration of SubForm component #13476
Comments
I have confirmed with team apps that we should allow the same layout set to be reused in multiple sub-form components. So no restrictions on that. |
This issue is blocked until #13477 is merged. |
I have two questions:
|
Could we maybe add the sketches as a screenshot? When I click the link it takes me to Figma, but there is a lot of sketches on the page 😅 @Annikenkbrathen |
Yes, I agree that my files might be a bit disorganized in Figma, so I understand that screenshots are easier. These sketches are still a work in progress, so perhaps it's better to just ask me when a developer starts working on this? |
Thank you, sounds good! 😄 |
Tested in dev - works as expected :) |
Background
The SubForm component implemented in the following issue includes more configuration options than are currently supported in Studio. To fully utilize the SubForm component, we need to extend Studio to support all necessary configurations. That is what this issue is all about.
Requirements:
layoutSet
property with layout sets that are specifically designed to function as sub-forms. To identify supported layoutSet we need to determine which layout sets can be used as sub-forms, we need to read a property inlayout-sets.json
. The name of this property is"type": "subform"
SubForm Component configuration looks like the following:
In this example, the component points to the moped-subform layoutset.
In addition, it points to a dataType - that is the default data type for the layoutset?
Details on
tableColumns
ConfigurationheaderContent: This defines a static title for the entire sub-form. The value should reference a text resource, serving as a label for the section.
cellContent: This specifies the content displayed for each row in the table. The value is a reference to a field in the data model. For instance, in the example provided, it points to "RegNo" and "Merke." The syntax follows dot notation, meaning the fields mentioned in the example are located at the root level of the data model. If the field is nested within an object, the configuration could look like
query: Person.firstName
, wherefirstName
is a field within thePerson
object.Based on the information above, we need a UI that allows users to select fields from the data model to use as query in cellContent. Content design is necessary to clearly communicate the purpose and of these configurations to ensure a great user experience.
Tasks
Note
In general, we should figure out a pattern to easily adopt new configurations as Team Apps come with new features that require new configurations.
Acceptance criteria
SubForm
component at a relevant sub-form layoutset.SubForm
component to a sub-form layoutset that is already used elsewhere.tableColumns
propertyThe text was updated successfully, but these errors were encountered: