Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of about/overview/administration page #11258

Merged
merged 16 commits into from
Oct 11, 2023

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Sep 29, 2023

Description

Related Issue(s)

Verification

@mlqn mlqn linked an issue Sep 29, 2023 that may be closed by this pull request
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b58d2c4) 81.53% compared to head (b9a0f07) 81.53%.
Report is 4 commits behind head on master.

❗ Current head b9a0f07 differs from pull request most recent head 45271bb. Consider uploading reports for the commit 45271bb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11258   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files         808      809    +1     
  Lines       12155    12170   +15     
  Branches     1609     1612    +3     
=======================================
+ Hits         9910     9923   +13     
- Misses       2006     2007    +1     
- Partials      239      240    +1     
Files Coverage Δ
...administration/components/LegacyAdministration.tsx 100.00% <100.00%> (ø)
...dministration/components/ServiceAdministration.tsx 94.44% <100.00%> (-0.11%) ⬇️
...app-development/hooks/queries/useAppConfigQuery.ts 100.00% <100.00%> (ø)
...nd/packages/shared/src/utils/featureToggleUtils.ts 87.17% <ø> (ø)
frontend/app-development/config/routes.tsx 91.66% <66.66%> (-8.34%) ⬇️
...tures/administration/components/Administration.tsx 85.71% <81.81%> (-9.94%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn marked this pull request as ready for review October 4, 2023 10:21
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! 🚀 Just a few small comments for consideration. 😊

@mlqn mlqn force-pushed the 11155-implement-new-page-with-placeholders branch from b540a34 to 5b85cf0 Compare October 9, 2023 13:16
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mlqn mlqn merged commit 51bf202 into master Oct 11, 2023
10 of 12 checks passed
@mlqn mlqn deleted the 11155-implement-new-page-with-placeholders branch October 11, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new page with placeholders
2 participants