Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backend tests #11324

Merged
merged 18 commits into from
Oct 12, 2023
Merged

fix: backend tests #11324

merged 18 commits into from
Oct 12, 2023

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Oct 9, 2023 •
edited
Loading

Description

Splits the dotnet test command in multiple to avoid memory pressure.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Oct 9, 2023
@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 9, 2023
@mirkoSekulic mirkoSekulic force-pushed the hotfix/optimize-tests branch 2 times, most recently from b53beb7 to 5faf733 Compare October 11, 2023 21:44
@mirkoSekulic mirkoSekulic enabled auto-merge (squash) October 11, 2023 22:05
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (75b0cef) 81.72% compared to head (7c3013a) 81.72%.
Report is 1 commits behind head on master.

❗ Current head 7c3013a differs from pull request most recent head 422983e. Consider uploading reports for the commit 422983e to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11324   +/-   ##
=======================================
  Coverage   81.72%   81.72%           
=======================================
  Files         811      811           
  Lines       12191    12191           
  Branches     1613     1613           
=======================================
  Hits         9963     9963           
  Misses       1988     1988           
  Partials      240      240

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirkoSekulic mirkoSekulic linked an issue Oct 12, 2023 that may be closed by this pull request
Make backend tests stabile in pipelines #10966
Closed
standeren
standeren approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥳

@mirkoSekulic mirkoSekulic merged commit 76860e7 into master Oct 12, 2023
8 checks passed
@mirkoSekulic mirkoSekulic deleted the hotfix/optimize-tests branch October 12, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standeren standeren standeren approved these changes

Assignees
No one assigned
Labels
quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make backend tests stabile in pipelines
2 participants
@mirkoSekulic @standeren