Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/10591 deploy resource #11336

Merged
58 commits merged into from
Oct 16, 2023
Merged

Feature/10591 deploy resource #11336

58 commits merged into from
Oct 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2023

Description

  • Implementing deploy resource
  • Finalising the style of the deploy page
  • Adding tests to the deploy page
  • Refactoring logic on how to display error messages
  • Changing the validation of policy in backend to return an object with the status and a message even if the policy does not exists.
  • @TheTechArch updated backend APIs to work for deploying a resource to the environments.

Related Issue(s)

Video of behaviour

Screen.Recording.2023-10-11.at.13.16.59.mov

Verification

wrt95 and others added 30 commits September 14, 2023 08:21
@ghost ghost requested review from TheTechArch and framitdavid October 11, 2023 11:37
@ghost ghost self-assigned this Oct 11, 2023
@ghost ghost marked this pull request as draft October 11, 2023 11:37
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (a955087) 81.70% compared to head (17aa48c) 82.14%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11336      +/-   ##
==========================================
+ Coverage   81.70%   82.14%   +0.43%     
==========================================
  Files         812      813       +1     
  Lines       12189    12235      +46     
  Branches     1618     1629      +11     
==========================================
+ Hits         9959    10050      +91     
+ Misses       1989     1937      -52     
- Partials      241      248       +7     
Files Coverage Δ
frontend/packages/shared/src/api/paths.js 100.00% <100.00%> (ø)
frontend/packages/shared/src/mocks/queriesMock.ts 100.00% <ø> (ø)
frontend/packages/shared/src/types/QueryKey.ts 100.00% <ø> (ø)
...ts/ResourceDeployEnvCard/ResourceDeployEnvCard.tsx 100.00% <100.00%> (+16.66%) ⬆️
...ents/ResourceDeployStatus/ResourceDeployStatus.tsx 100.00% <100.00%> (+20.00%) ⬆️
...components/ResourceNameAndId/ResourceNameAndId.tsx 84.00% <ø> (ø)
frontend/resourceadm/hooks/mutations/index.ts 100.00% <100.00%> (ø)
...oks/queries/useResourcePolicyPublishStatusQuery.ts 100.00% <100.00%> (+42.85%) ⬆️
...ourceadm/hooks/queries/useValidateResourceQuery.ts 100.00% <100.00%> (ø)
...eadm/pages/AboutResourcePage/AboutResourcePage.tsx 74.79% <100.00%> (+0.20%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost marked this pull request as ready for review October 11, 2023 14:16
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@ghost ghost merged commit 64d10f8 into master Oct 16, 2023
13 of 14 checks passed
@ghost ghost deleted the feature/10591-deploy-resource branch October 16, 2023 07:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Status: ✅✅Closed
Development

Successfully merging this pull request may close these issues.

3 participants