-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/10591 deploy resource #11336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/10591-deploy-resource
…re/10591-deploy-resource
…re/10591-deploy-resource
…re/10591-deploy-resource
…tinn/altinn-studio into feature/10591-deploy-resource
ghost
self-assigned this
Oct 11, 2023
ghost
marked this pull request as draft
October 11, 2023 11:37
github-actions
bot
added
the
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
label
Oct 11, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11336 +/- ##
==========================================
+ Coverage 81.70% 82.14% +0.43%
==========================================
Files 812 813 +1
Lines 12189 12235 +46
Branches 1618 1629 +11
==========================================
+ Hits 9959 10050 +91
+ Misses 1989 1937 -52
- Partials 241 248 +7
☔ View full report in Codecov by Sentry. |
backend/src/Designer/Services/Implementation/ResourceRegistryService.cs
Dismissed
Show dismissed
Hide dismissed
backend/src/Designer/Services/Implementation/ResourceRegistryService.cs
Dismissed
Show dismissed
Hide dismissed
ghost
marked this pull request as ready for review
October 11, 2023 14:16
framitdavid
reviewed
Oct 16, 2023
frontend/resourceadm/components/ResourceDeployEnvCard/ResourceDeployEnvCard.tsx
Outdated
Show resolved
Hide resolved
framitdavid
reviewed
Oct 16, 2023
frontend/resourceadm/components/ResourceDeployEnvCard/ResourceDeployEnvCard.tsx
Outdated
Show resolved
Hide resolved
framitdavid
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!👍
ghost
deleted the
feature/10591-deploy-resource
branch
October 16, 2023 07:27
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Video of behaviour
Screen.Recording.2023-10-11.at.13.16.59.mov
Verification