-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/10670 import service from altinn 2 #11384
Conversation
…github.com/Altinn/altinn-studio into feature/10670-import-service-from-Altinn-2
…github.com/Altinn/altinn-studio into feature/10670-import-service-from-Altinn-2
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11384 +/- ##
==========================================
+ Coverage 82.73% 82.76% +0.02%
==========================================
Files 828 837 +9
Lines 12524 12589 +65
Branches 1674 1679 +5
==========================================
+ Hits 10362 10419 +57
- Misses 1900 1908 +8
Partials 262 262
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will continue as the first thing tomorrow. It's a little late now. 😴
frontend/resourceadm/components/ImportResourceModal/ImportResourceModal.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ImportResourceModal/ImportResourceModal.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ImportResourceModal/ImportResourceModal.tsx
Outdated
Show resolved
Hide resolved
frontend/resourceadm/components/ImportResourceModal/ServiceContent/ServiceContent.module.css
Outdated
Show resolved
Hide resolved
...esourceadm/components/ImportResourceModal/ServiceContent/ResourceContent/ResourceContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I just have a few things for considerations.
frontend/resourceadm/components/ImportResourceModal/ImportResourceModal.tsx
Outdated
Show resolved
Hide resolved
...esourceadm/components/ImportResourceModal/ServiceContent/ResourceContent/ResourceContent.tsx
Outdated
Show resolved
Hide resolved
...esourceadm/components/ImportResourceModal/ServiceContent/ResourceContent/ResourceContent.tsx
Outdated
Show resolved
Hide resolved
…github.com/Altinn/altinn-studio into feature/10670-import-service-from-Altinn-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏
…github.com/Altinn/altinn-studio into feature/10670-import-service-from-Altinn-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
if (OrgUtil.IsTestEnv(org)) | ||
{ | ||
linkServices = unfiltered.Where(a => a.ServiceType.Equals(ServiceType.Link) && (a.ServiceOwnerCode.ToLower().Equals(org.ToLower()) || a.ServiceOwnerCode.ToLower().Equals("acn"))).ToList(); | ||
} | ||
else | ||
{ | ||
linkServices = unfiltered.Where(a => a.ServiceType.Equals(ServiceType.Link) && a.ServiceOwnerCode.ToLower().Equals(org.ToLower())).ToList(); | ||
} |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
* adding basic frontend logic * spll check * typofix * Fixed spelling * Adding style * Fixed ttd handling * Adding handling for service * fixing code * Fixed cache key * Changed to post for import * Trying to set up import * Trying to fix undefined * fixing undefined * updating post * Cleaning up cod * Adding tests * fixing queriesMock * rollback useGetResourceList * dotnet format * Fixed method * Fixing modal z index and SetupTab * Fixing feedback fromPR * Adding ServerCode enum * Feedback. Added util fo rcommmon org code --------- Co-authored-by: Rune T. Larsen <rune@hjemmekino.no>
* adding basic frontend logic * spll check * typofix * Fixed spelling * Adding style * Fixed ttd handling * Adding handling for service * fixing code * Fixed cache key * Changed to post for import * Trying to set up import * Trying to fix undefined * fixing undefined * updating post * Cleaning up cod * Adding tests * fixing queriesMock * rollback useGetResourceList * dotnet format * Fixed method * Fixing modal z index and SetupTab * Fixing feedback fromPR * Adding ServerCode enum * Feedback. Added util fo rcommmon org code --------- Co-authored-by: Rune T. Larsen <rune@hjemmekino.no>
Description
Related Issue(s)
Verification