Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apps extended version of appmetadata csharp model #11435

Conversation

standeren
Copy link
Contributor

Description

Add packagereference from Altinn.Apps.Api
Change all usages of Platform Application Metadata model to use Apps extended model instead

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a553f0f) 82.79% compared to head (155b4be) 82.79%.
Report is 4 commits behind head on master.

❗ Current head 155b4be differs from pull request most recent head a579a7f. Consider uploading reports for the commit a579a7f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11435   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files         827      827           
  Lines       12505    12505           
  Branches     1680     1680           
=======================================
  Hits        10354    10354           
  Misses       1889     1889           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren merged commit 38435d5 into master Oct 26, 2023
9 checks passed
@standeren standeren deleted the 11357-change-application-c-model-to-app-lib-applicationmetadata-model-in-backend branch October 26, 2023 11:05
nkylstad pushed a commit that referenced this pull request Nov 1, 2023
* Use apps extended version of appmetadata csharp model

* Remove 'onEntry' from appmetadata

* Move version to package group
nkylstad pushed a commit that referenced this pull request Nov 5, 2023
* Use apps extended version of appmetadata csharp model

* Remove 'onEntry' from appmetadata

* Move version to package group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Application c# model to app-lib ApplicationMetaData model in backend
2 participants