-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11559 deploy regression test w46 #11596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dette ser bra ut, men se om du kan finne riktig menyknapp uten å bruke indeks. Testen burde ikke være avhengig av at ting vises i en gitt rekkefølge.
For øvrig burde vi kanskje vurdere å heller bruke "Felter"-fanen. For brukeren er det i hvert fall enklere. Jeg vet ikke om du også har prøvd det, men jeg prøvde i hvert fall lokalt, og det viser seg at det ikke er helt rett frem. Tror det er noe med lagringsalgoritmen som forvirrer Cypress, så man får sporadiske feil. Så vi får bruke din metode inntil videre 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11596 +/- ##
=======================================
Coverage 83.70% 83.70%
=======================================
Files 883 883
Lines 13052 13052
Branches 1711 1711
=======================================
Hits 10925 10925
Misses 1868 1868
Partials 259 259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
Related Issue(s)
Verification
Documentation