Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11559 deploy regression test w46 #11596

Merged
merged 9 commits into from
Nov 21, 2023

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Nov 15, 2023

Description

  • Added cypress test for the last two things in datamodels:
  • Add two string fields (name: text1 and text2) and one integer field (name: number1) to the newly added object.
  • Click the "Generate models" button and see that models are created.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Nov 15, 2023 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Nov 15, 2023
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette ser bra ut, men se om du kan finne riktig menyknapp uten å bruke indeks. Testen burde ikke være avhengig av at ting vises i en gitt rekkefølge.

For øvrig burde vi kanskje vurdere å heller bruke "Felter"-fanen. For brukeren er det i hvert fall enklere. Jeg vet ikke om du også har prøvd det, men jeg prøvde i hvert fall lokalt, og det viser seg at det ikke er helt rett frem. Tror det er noe med lagringsalgoritmen som forvirrer Cypress, så man får sporadiske feil. Så vi får bruke din metode inntil videre 👍

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3819510) 83.70% compared to head (0e69279) 83.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11596   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         883      883           
  Lines       13052    13052           
  Branches     1711     1711           
=======================================
  Hits        10925    10925           
  Misses       1868     1868           
  Partials      259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JamalAlabdullah JamalAlabdullah merged commit bf55c5a into master Nov 21, 2023
9 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 11559-deploy-regression-test-w46 branch November 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy & regression test w46
2 participants