Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yarn): update to yarn 4 #11676

Merged
merged 3 commits into from
Nov 27, 2023
Merged

chore(yarn): update to yarn 4 #11676

merged 3 commits into from
Nov 27, 2023

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Nov 24, 2023

Description

This was quite straightforward to update. The only breaking change that affected us was that workspaces foreach command has a slightly altered syntax.

How I verified the change

  • Cypress tests run green locally (except of resourceadm)
  • All unit tests passed locally
  • Manually tested all packages and build
  • DevServer works as expected
  • Deleted the node-modules and re-installed all deps

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Nov 24, 2023
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1506614) 83.87% compared to head (098b08a) 83.87%.

❗ Current head 098b08a differs from pull request most recent head 81bc4cc. Consider uploading reports for the commit 81bc4cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11676   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         887      887           
  Lines       13033    13033           
  Branches     1699     1699           
=======================================
  Hits        10931    10931           
  Misses       1845     1845           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid merged commit 0ad3a9c into master Nov 27, 2023
1 check passed
@framitdavid framitdavid deleted the chore/updateYarnToYarn4 branch November 27, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants