Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwright): setup and config #11836

Merged
merged 60 commits into from
Jan 14, 2024
Merged

feat(playwright): setup and config #11836

merged 60 commits into from
Jan 14, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Dec 11, 2023

Description

Playwright Configuration for End-to-End (e2e) Tests in Studio

Have configured Playwright to write end-to-end (e2e) tests in Studio. We have a team meeting after the New Year that will focus on defining a test strategy. Therefore, new tests should not be created until we have completed the meeting and documented our desired testing approach.

Changes in this Pull Request (PR)

  1. Documentation: Describes how to set up the tests locally. See details here.
  2. Configuration: Enables login and session sharing between tests.
  3. Example Test: Includes an example test named simple-schema-app that logs in and creates an app.
  4. Teardown Implementation: Deletes the app created during the test when it is completed.
  5. Parameter Support: Allows passing parameters to the tests, such as different app names.
  6. Helper Classes: Includes helper classes containing logic to simplify test writing.
  7. Gitignore Update: Adds files that should not be included in Git.

Note

I have created a own issue to ensure to run this tests within the pipeline on PR and merge to master. We do also need to ensure that the test reports is presented within the Github interface. issue 11991

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@framitdavid framitdavid marked this pull request as draft December 11, 2023 14:18
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes labels Dec 11, 2023
@github-actions github-actions bot removed the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Dec 11, 2023
@github-actions github-actions bot added the kind/dependencies Used for issues or pull requests that are dependency updates label Dec 11, 2023
@framitdavid framitdavid marked this pull request as ready for review January 10, 2024 09:28
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fremragende arbeid! Har noen små forslag, men ser ikke noe jeg mener er kritisk. Overlater denne til resten av teamet nå siden jeg ikke er tilbake på jobb før neste uke.

frontend/testing/playwright/pages/CreateServicePage.ts Outdated Show resolved Hide resolved
frontend/testing/playwright/playwright.config.ts Outdated Show resolved Hide resolved
frontend/testing/playwright/scripts/setup.ts Show resolved Hide resolved
frontend/testing/playwright/README.md Outdated Show resolved Hide resolved
frontend/testing/playwright/README.md Outdated Show resolved Hide resolved
frontend/testing/playwright/integration/auth.setup.ts Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good, impressive work👏🏻 I have a question and one suggestion 😄

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@framitdavid framitdavid merged commit 9cf4b6f into master Jan 14, 2024
9 of 10 checks passed
@framitdavid framitdavid deleted the feat/playwright branch January 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic setup for Playwright tests
2 participants