Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11791 connect bpmn task with datamodel #11897

Closed
wants to merge 51 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2023

Description

  • Implemented functionality to add a data type to a task in the bpmn process-editor

Related Issue(s)

Video

Screen.Recording.2023-12-19.at.08.40.59.mov

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). solution/studio/designer Issues related to the Altinn Studio Designer solution. skip-releasenotes Issues that do not make sense to list in our release notes labels Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e15b4c1) 86.38% compared to head (bf9a1c4) 86.42%.

Files Patch % Lines
...tor/src/utils/configPanelUtils/configPanelUtils.ts 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11897      +/-   ##
==========================================
+ Coverage   86.38%   86.42%   +0.04%     
==========================================
  Files         904      906       +2     
  Lines       12959    13013      +54     
  Branches     1623     1628       +5     
==========================================
+ Hits        11194    11247      +53     
  Misses       1533     1533              
- Partials      232      233       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Dec 20, 2023
@ghost ghost linked an issue Dec 20, 2023 that may be closed by this pull request
5 tasks
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette ser alt i alt veldig ryddig ut!

@@ -650,6 +650,11 @@
"process_editor.configuration_panel_name_label": "Navn: ",
"process_editor.configuration_panel_no_task": "Velg et element i prosessen for å se detaljer.",
"process_editor.configuration_panel_signing_task": "Oppgave: Signering",
"process_editor.create_new_datamodel_link": "Lag ny datamodell",
"process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, evt. hvilken datamodell som er knyttet til datatypen, mm.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, evt. hvilken datamodell som er knyttet til datatypen, mm.",
"process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. et skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, ev. hvilken datamodell som er knyttet til datatypen, mm.",

* @returns a filtered list of DataTypeElements
*/
export const filterOutRefDataAsPdf = (dataTypes: DataTypeElement[]): DataTypeElement[] => {
return dataTypes.filter((dataType: DataTypeElement) => dataType.id !== 'ref-data-as-pdf');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva med å lage et array som heter unsupportedDataTypes eller noe i den duren som inneholder denne verdien? Det kan virke litt unødvendig siden det bare er én verdi, men da blir det i hvert fall tydelig hvorfor den blir filtrert ut.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, enig 😄


const showCreateDatamodelLink: boolean = validDataTypeIdsAndTaskIds.length === 0;

const dataTypeOptions = validDataTypeIdsAndTaskIds.map((data) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legg gjerne til type her. Den kan importeres fra designsystemet.

Suggested change
const dataTypeOptions = validDataTypeIdsAndTaskIds.map((data) => ({
const dataTypeOptions: MultiSelectOption[] = validDataTypeIdsAndTaskIds.map((data) => ({

@ghost ghost requested a review from TomasEng December 20, 2023 14:18
Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg lurer på om vi burde gå et lite skritt tilbake og se på hele implementasjonen av konfigurering av datatype-layoutset-task-knytningen da jeg føler det er mer komplekst enn vi kanskje har forutsett. Ref slack-innlegg.

Så jeg mener vi burde vente litt med å merge denne endringen 🫣

@ghost
Copy link
Author

ghost commented Jan 15, 2024

Closing this as we need to find out how it should be implemented in the best possible way first. See the issue for more information.

@ghost ghost closed this Jan 15, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement frontend for selecting a data type for a selected task
3 participants