Feature/11791 connect bpmn task with datamodel #11897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out-selected-task
…1791-connect-bpmn-task-with-datamodel
…1791-connect-bpmn-task-with-datamodel
github-actions
bot
added
area/process
ghost
commented
Dec 19, 2023
ghost
commented
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11897 +/- ##
==========================================
+ Coverage 86.38% 86.42% +0.04%
==========================================
Files 904 906 +2
Lines 12959 13013 +54
Branches 1623 1628 +5
==========================================
+ Hits 11194 11247 +53
Misses 1533 1533
- Partials 232 233 +1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
area/ui-editor
ghost
commented
Dec 20, 2023
.../ux-editor/src/components/config/componentSpecificContent/FileUpload/FileUploadComponent.tsx
Show resolved
Hide resolved
5 tasks
TomasEng
reviewed
Dec 20, 2023
frontend/language/src/nb.json
Outdated
| @@ -650,6 +650,11 @@ | |||
| "process_editor.configuration_panel_name_label": "Navn: ", | |||
| "process_editor.configuration_panel_no_task": "Velg et element i prosessen for å se detaljer.", | |||
| "process_editor.configuration_panel_signing_task": "Oppgave: Signering", | |||
| "process_editor.create_new_datamodel_link": "Lag ny datamodell", | |||
| "process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, evt. hvilken datamodell som er knyttet til datatypen, mm.", | |||
There was a problem hiding this comment.
Suggested change
| "process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, evt. hvilken datamodell som er knyttet til datatypen, mm.", | |
| "process_editor.datatype_helptext_content": " En datatype spesifiserer hva slags data man forventer. Det kan være en datamodell (for strukturerte data fra f.eks. et skjema), eller spesifikasjon av binære vedlegg. Datatypen inneholder metadata om dataene, som f.eks. antall dataelementer av den typen, ev. hvilken datamodell som er knyttet til datatypen, mm.", |
| * @returns a filtered list of DataTypeElements | ||
| */ | ||
| export const filterOutRefDataAsPdf = (dataTypes: DataTypeElement[]): DataTypeElement[] => { | ||
| return dataTypes.filter((dataType: DataTypeElement) => dataType.id !== 'ref-data-as-pdf'); |
There was a problem hiding this comment.
Hva med å lage et array som heter unsupportedDataTypes eller noe i den duren som inneholder denne verdien? Det kan virke litt unødvendig siden det bare er én verdi, men da blir det i hvert fall tydelig hvorfor den blir filtrert ut.
|
|
||
| const showCreateDatamodelLink: boolean = validDataTypeIdsAndTaskIds.length === 0; | ||
|
|
||
| const dataTypeOptions = validDataTypeIdsAndTaskIds.map((data) => ({ |
There was a problem hiding this comment.
Legg gjerne til type her. Den kan importeres fra designsystemet.
Suggested change
| const dataTypeOptions = validDataTypeIdsAndTaskIds.map((data) => ({ | |
| const dataTypeOptions: MultiSelectOption[] = validDataTypeIdsAndTaskIds.map((data) => ({ |
ghost
requested a review
from 
standeren
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Jeg lurer på om vi burde gå et lite skritt tilbake og se på hele implementasjonen av konfigurering av datatype-layoutset-task-knytningen da jeg føler det er mer komplekst enn vi kanskje har forutsett. Ref slack-innlegg.
Så jeg mener vi burde vente litt med å merge denne endringen 🫣
ghost
mentioned this pull request
5 tasks
|
Closing this as we need to find out how it should be implemented in the best possible way first. See the issue for more information. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Video
Screen.Recording.2023-12-19.at.08.40.59.mov
Verification