Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the EditDataModelBindings tests #12006

Merged
4 commits merged into from
Jan 12, 2024
Merged

Fixing the EditDataModelBindings tests #12006

4 commits merged into from
Jan 12, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2024

Description

  • fixing what is left in the issue

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ghost ghost linked an issue Jan 11, 2024 that may be closed by this pull request
Flaky and false positive tests on EditDataModelBindings #11893
Closed
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Jan 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c6cdfe) 86.93% compared to head (f676ce1) 86.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #12006   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files         934      934           
  Lines       13373    13373           
  Branches     1636     1636           
=======================================
  Hits        11626    11626           
  Misses       1535     1535           
  Partials      212      212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lassopicasso
lassopicasso approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment below, well done! 👍

frontend/packages/ux-editor/src/components/config/editModal/EditDataModelBindings.tsx Outdated Show resolved Hide resolved
@ghost ghost merged commit 4699b01 into master Jan 12, 2024
11 checks passed
@ghost ghost deleted the bug-fix/11893-EditDataModelBindings-test-fix branch January 12, 2024 08:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky and false positive tests on EditDataModelBindings
2 participants
@lassopicasso @wrt95