Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the EditDataModelBindings tests #12006

Merged
4 commits merged into from
Jan 12, 2024
Merged

Fixing the EditDataModelBindings tests #12006

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a98f1e
fixing the tests
wrt95 Jan 11, 2024
7fa5000
removing unused code
wrt95 Jan 12, 2024
fd43623
Merge branch 'master' into bug-fix/11893-EditDataModelBindings-test-fix
wrt95 Jan 12, 2024
f676ce1
trying to run again
wrt95 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions frontend/packages/ux-editor/src/components/config/editModal/EditDataModelBindings.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { ComponentType } from 'app-shared/types/ComponentType';
import userEvent from '@testing-library/user-event';
import { DatamodelMetadataResponse } from 'app-shared/types/api';

const user = userEvent.setup();

const datamodelMetadata: DatamodelMetadataResponse = {
elements: {
testModel: {
Expand Down Expand Up @@ -84,7 +82,10 @@ const render = async ({ dataModelBindings = {}, handleComponentChange = jest.fn(
};

describe('EditDataModelBindings', () => {
afterEach(jest.clearAllMocks);

it('should show select with no selected option by default', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -95,6 +96,7 @@ describe('EditDataModelBindings', () => {
});

it('should show select with provided data model binding', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -111,6 +113,7 @@ describe('EditDataModelBindings', () => {
});

it('should show select when link icon is clicked', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -119,6 +122,7 @@ describe('EditDataModelBindings', () => {
});

it('should toggle select on link icon click', async () => {
const user = userEvent.setup();
await render();
expect(screen.queryByRole('combobox')).not.toBeInTheDocument();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
Expand All @@ -127,6 +131,7 @@ describe('EditDataModelBindings', () => {
});

it('check that handleComponentChange is called', async () => {
const user = userEvent.setup();
const handleComponentChange = jest.fn();
await render({ handleComponentChange });
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
Expand All @@ -145,6 +150,7 @@ describe('EditDataModelBindings', () => {
});

it('should render save icon', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -153,6 +159,7 @@ describe('EditDataModelBindings', () => {
});

it('should render delete icon', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -161,6 +168,7 @@ describe('EditDataModelBindings', () => {
});

it('show link data model again when click on save button and no data model binding is selected', async () => {
const user = userEvent.setup();
await render();
const linkIcon = screen.getByText(textMock('ux_editor.modal_properties_data_model_link'));
await act(() => user.click(linkIcon));
Expand All @@ -178,6 +186,7 @@ describe('EditDataModelBindings', () => {
});

it('deletes existing data model link', async () => {
const user = userEvent.setup();
const handleComponentChange = jest.fn();
const dataModelBindingKey = 'testModel.field1';

Expand Down Expand Up @@ -209,6 +218,7 @@ describe('EditDataModelBindings', () => {
});

it('shows edit form', async () => {
const user = userEvent.setup();
const dataModelBindingKey = 'testModel.field1';
await render({
dataModelBindings: { simpleBinding: dataModelBindingKey },
Expand Down Expand Up @@ -244,6 +254,7 @@ describe('EditDataModelBindings', () => {
}}
/>,
);

expect(await screen.findByText('testModel.field2')).toBeInTheDocument();
});
});
Loading