-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12175 move texts configs into separate section #12238
12175 move texts configs into separate section #12238
Conversation
018bbd4
to
4b2ee7b
Compare
4b2ee7b
to
2130258
Compare
Great work @standeren! 🥳 I think this PR is ready for review now, fingers crossed that the tests pipeline runs ok now! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12238 +/- ##
==========================================
+ Coverage 86.38% 86.43% +0.05%
==========================================
Files 1198 1198
Lines 18099 18080 -19
Branches 2296 2295 -1
==========================================
- Hits 15635 15628 -7
+ Misses 2174 2166 -8
+ Partials 290 286 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀 I'm publishing what I've reviewed so far, but I didn't quite finish before I had to leave. I'll continue with the review in the next work session. 😊
frontend/packages/ux-editor/src/components/config/editModal/EditCodeList/EditCodeList.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/TextResource.module.css
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditOptions.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditOptions.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚀
edf7c93
to
82349f0
Compare
…igs-into-separate-section
Description
Move text config to separate section in config-panel. Both components and containers uses schema for this.
Also some small design changes:
Simple component
Group component
Related Issue(s)
Verification