Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12175 move texts configs into separate section #12238

Merged
merged 27 commits into from
Feb 12, 2024

Conversation

standeren
Copy link
Contributor

@standeren standeren commented Feb 2, 2024

Description

Move text config to separate section in config-panel. Both components and containers uses schema for this.
Also some small design changes:

  • Removing the legacySelect which was default from schema and render all available texts by default
  • Add white box behind each text resource

Simple component
Skjermbilde 2024-02-02 kl  15 10 40

Group component
Skjermbilde 2024-02-02 kl  15 11 16

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 2, 2024
@standeren standeren force-pushed the 12175-move-texts-configs-into-separate-section branch from 018bbd4 to 4b2ee7b Compare February 2, 2024 15:05
@standeren standeren force-pushed the 12175-move-texts-configs-into-separate-section branch from 4b2ee7b to 2130258 Compare February 2, 2024 16:12
@nkylstad nkylstad linked an issue Feb 5, 2024 that may be closed by this pull request
@nkylstad nkylstad self-assigned this Feb 5, 2024
@nkylstad
Copy link
Member

nkylstad commented Feb 5, 2024

Great work @standeren! 🥳
I have made some small changes to fix the [mockedText(...)] issue.
In addition I moved the options config section to the texts section, as per the design for the text section.

I think this PR is ready for review now, fingers crossed that the tests pipeline runs ok now!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (61cc10e) 86.38% compared to head (53eb35e) 86.43%.
Report is 1 commits behind head on main.

Files Patch % Lines
...kages/ux-editor/src/components/Properties/Text.tsx 76.66% 7 Missing ⚠️
...nts/config/editModal/EditCodeList/EditCodeList.tsx 90.00% 0 Missing and 1 partial ⚠️
...or/src/components/config/editModal/EditOptions.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12238      +/-   ##
==========================================
+ Coverage   86.38%   86.43%   +0.05%     
==========================================
  Files        1198     1198              
  Lines       18099    18080      -19     
  Branches     2296     2295       -1     
==========================================
- Hits        15635    15628       -7     
+ Misses       2174     2166       -8     
+ Partials      290      286       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad removed their assignment Feb 7, 2024
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 I'm publishing what I've reviewed so far, but I didn't quite finish before I had to leave. I'll continue with the review in the next work session. 😊

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@nkylstad nkylstad force-pushed the 12175-move-texts-configs-into-separate-section branch from edf7c93 to 82349f0 Compare February 12, 2024 18:42
@nkylstad nkylstad merged commit fb9e666 into main Feb 12, 2024
11 checks passed
@nkylstad nkylstad deleted the 12175-move-texts-configs-into-separate-section branch February 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move texts configs into separate section
3 participants