Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proccess file sync #12246

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Proccess file sync #12246

merged 4 commits into from
Feb 5, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Feb 5, 2024

  • Add MediatR package
  • event and event handlers structure added
  • fix endpoint and add tests
  • delete taskName change endpoint

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Feb 5, 2024
@mirkoSekulic mirkoSekulic force-pushed the feature/file-sync branch 2 times, most recently from 25ada23 to 29630a1 Compare February 5, 2024 11:32
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6f0c29) 86.42% compared to head (1bd7b07) 86.42%.
Report is 1 commits behind head on main.

❗ Current head 1bd7b07 differs from pull request most recent head ce0ff2b. Consider uploading reports for the commit ce0ff2b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12246   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files        1188     1188           
  Lines       18049    18049           
  Branches     2292     2292           
=======================================
  Hits        15598    15598           
  Misses       2163     2163           
  Partials      288      288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirkoSekulic mirkoSekulic removed the skip-releasenotes Issues that do not make sense to list in our release notes label Feb 5, 2024
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I added one comment, just for consideration/out of curiosity 😊

@mirkoSekulic mirkoSekulic merged commit b5fb51e into main Feb 5, 2024
11 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/file-sync branch February 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants