Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sensible email adress for git in altinn studio #12520

Closed
wants to merge 1 commit into from

Conversation

nkylstad
Copy link
Member

Description

@ivarne was going through some old bugs and found this in one of the comments 😂 Not sure why we never did anything about this, but I see no reason to not just incorporate this change now!

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Mar 15, 2024
@ivarne
Copy link
Member

ivarne commented Mar 15, 2024

❤️❤️❤️

@ivarne
Copy link
Member

ivarne commented Mar 15, 2024

The likely reason I did not click "open PR" is that I didn't have the time to run studio locally and verify that it actually worked.

@nkylstad nkylstad changed the base branch from master to main March 15, 2024 14:16
@nkylstad
Copy link
Member Author

Something weird about the checks 🤔 Might be because I used the wrong base branch when I created the PR. I copied the code into a new branch and created a new PR, all checks run green: #12522
Also tested that branch on my machine, it works as expected there 🥳

@nkylstad nkylstad closed this Mar 15, 2024
@ivarne ivarne deleted the noJugglinutcase branch March 15, 2024 17:45
@lassopicasso lassopicasso self-assigned this Mar 25, 2024
@lassopicasso
Copy link
Contributor

lassopicasso commented Mar 25, 2024

Tested in dev - works like a charm.
One thing to note is that the email addresses differ when making changes in Altinn Studio compared to making them directly in Gitea.
When committing changes in Gitea directly: @noreply.altinn.no
In Studio: @noreply.altinn.studio
I'm not sure if this is intentional, or if we should use the same email address.
What are your thoughts, @nkylstad, @framitdavid ?
image

Gitea config:
image

@lassopicasso lassopicasso removed their assignment Mar 25, 2024
@ivarne
Copy link
Member

ivarne commented Mar 25, 2024

I would guess (hope) the reason for the discrepancy is that gitea(studio) changed their default committer author email after I suggested this for studio. Otherwise I made a mistake. The point was to make them equal. (Although it might be reasonable to make it more obvious where the commit was generated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants