Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11503 e2e tests for process editor #12976

Merged
merged 28 commits into from
Jun 24, 2024
Merged

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Jun 17, 2024

Description

  • Added end to end tests using Playwright for process-editor
  • Fixed some errors in language files
  • Fixed so that we can click a tasks in left-panel in the bpmn editor and then click somewhere in the editor where we want to place it (could only drag and drop before).
  • Fixed loading state issue in bpmn editor

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

wrt95 and others added 28 commits June 4, 2024 20:54
…thub.com:Altinn/altinn-studio into 12714-remove-feature-flag-and-update-url-to-docs
@wrt95 wrt95 linked an issue Jun 17, 2024 that may be closed by this pull request
@github-actions github-actions bot added the area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). label Jun 17, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (f2ba8b0) to head (8daf66b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12976      +/-   ##
==========================================
- Coverage   91.44%   91.44%   -0.01%     
==========================================
  Files        1400     1400              
  Lines       19814    19807       -7     
  Branches     2394     2392       -2     
==========================================
- Hits        18119    18112       -7     
  Misses       1431     1431              
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan self-requested a review June 20, 2024 06:38
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean and the spec file is well sectioned with comments. Nice work! 😄

@wrt95 wrt95 merged commit eb2d47f into main Jun 24, 2024
10 checks passed
@wrt95 wrt95 deleted the 11503-e2e-tests-for-process-editor branch June 24, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). quality/testing Tests that are missing, needs to be created or could be improved. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests for process editor
2 participants