Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deleting subform layoutset #13680

Merged
merged 7 commits into from
Oct 9, 2024
Merged

feat: deleting subform layoutset #13680

merged 7 commits into from
Oct 9, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Oct 2, 2024 •
edited
Loading

Description

Deletion of subform layoutsets is already implemented. This PR adds syncevent to remove components referencing the deleted subform layoutset.

  • Upon deleting a subform layoutset, any components referencing it should also be deleted
  • Cache should invalidate so no refreshing should be needed

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Oct 2, 2024
@Jondyr Jondyr added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 2, 2024
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Oct 2, 2024
@Jondyr Jondyr force-pushed the 13482-support-for-deleting-subform-layoutset branch from fbaea12 to c2e7124 Compare October 2, 2024 13:10
@Jondyr Jondyr marked this pull request as ready for review October 2, 2024 13:24
@Jondyr Jondyr linked an issue Oct 2, 2024 that may be closed by this pull request
Support for deleting subform-layoutset #13482
Closed
1 task
mlqn
mlqn approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀 It looks like the deletion of the layoutsets isn't fully implemented yet, as neither the applicationmetadata file nor the BPMN file are being updated when using the FileUpload and FileUploadWithTag components. So we might want to keep the issue linked to this PR open for now. 🤔

frontend/packages/shared/src/queryInvalidator/SyncSuccessQueriesInvalidator.ts Show resolved Hide resolved
@Jondyr
Copy link
Member Author

Jondyr commented Oct 7, 2024

It looks like the deletion of the layoutsets isn't fully implemented yet, as neither the applicationmetadata file nor the BPMN file are being updated when using the FileUpload and FileUploadWithTag components. So we might want to keep the issue linked to this PR open for now.

Good point, i will update the issue

@Jondyr Jondyr mentioned this pull request Oct 7, 2024
Closed
1 task
nkylstad
nkylstad approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested OK in dev 🥳
Added some comments to the related issue that we should consider going forward, but not a blocker for this PR.

@nkylstad
Copy link
Member

nkylstad commented Oct 9, 2024

@Jondyr There is an unresolved conversation in this PR blocking merge - I don't want to resolve it for you, want to take a look?

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (6a27c3a) to head (cb9398f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13680   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files        1619     1619           
  Lines       21706    21706           
  Branches     2567     2567           
=======================================
  Hits        20512    20512           
  Misses        943      943           
  Partials      251      251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr merged commit 55f2170 into main Oct 9, 2024
16 checks passed
@Jondyr Jondyr deleted the 13482-support-for-deleting-subform-layoutset branch October 9, 2024 13:26
@Jondyr
Copy link
Member Author

Jondyr commented Oct 9, 2024

@nkylstad Thanks for the heads up, resolved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

@mlqn mlqn mlqn approved these changes

Assignees
No one assigned
Labels
backend frontend quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for deleting subform-layoutset
3 participants
@Jondyr @nkylstad @mlqn