-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error occuring when adding a data task after creating a subform #13736
fix: Error occuring when adding a data task after creating a subform #13736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13736 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 1621 1621
Lines 21677 21678 +1
Branches 2549 2549
=======================================
+ Hits 20495 20496 +1
Misses 939 939
Partials 243 243 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and I wonder about the erro-toast that showing when adding a task?
https://github.com/user-attachments/assets/c9421389-1a4b-4618-9cb3-a845c4a1e697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bra jobba😊; I tested it now and works fine.
…k-after-creating-a-subform
Added label |
Description
This fixes an error that occurs when adding a new task in the process editor, when
layout-sets.json
contains a layout set without thetasks
property. The solution was to add null checks.Since we now allow layout sets to not contain tasks (which is the case for subform layout sets), we have to check if the
tasks
property exists before trying to access it.Note: the backend build warnings in the PR comments should likely be solved en masse, see this issue: #13738
Related Issue(s)
Verification