refactor: Refactor the SchemaModel class with a base class

[TomasEng]

Description

Moved some basic, non-modifying methods from SchemaModel to a new class named SchemaModelBase, which is used a base for the SchemaModel class. This new class will be used as a base class when splitting up SchemaModel into several classes with different responsibilities.

This implies that the added method in #13783 can be rewritten like this:

  public willResultInCircularReferences(
    childSchemaPointer: string,
    parentSchemaPointer: string,
  ): boolean {
    const circularReferenceDetector = new CircularReferenceDetector(this.nodeMap);
    return circularReferenceDetector.willResultInCircularReferences(childSchemaPointer, parentSchemaPointer);
  }

Here, CircularReferenceDetector is a class that extends SchemaModelBase and contains all the relevant private methods.

Related Issues

• Studio crashes when adding type to the same type #13239
• fix: Check for circular references #13783

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (31d5ec1) to head (b6e9b0c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13812   +/-   ##
=======================================
  Coverage   95.29%   95.30%           
=======================================
  Files        1648     1650    +2     
  Lines       21956    21963    +7     
  Branches     2581     2581           
=======================================
+ Hits        20924    20931    +7     
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ErlingHauan]

Godt jobbet! Fint å få delt opp denne koden litt.