-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor the SchemaModel class with a base class #13812
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13812 +/- ##
=======================================
Coverage 95.29% 95.30%
=======================================
Files 1648 1650 +2
Lines 21956 21963 +7
Branches 2581 2581
=======================================
+ Hits 20924 20931 +7
Misses 787 787
Partials 245 245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godt jobbet! Fint å få delt opp denne koden litt.
Description
Moved some basic, non-modifying methods from
SchemaModel
to a new class namedSchemaModelBase
, which is used a base for theSchemaModel
class. This new class will be used as a base class when splitting upSchemaModel
into several classes with different responsibilities.This implies that the added method in #13783 can be rewritten like this:
Here,
CircularReferenceDetector
is a class that extendsSchemaModelBase
and contains all the relevant private methods.Related Issues
Verification