Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subform): Add SubFormMissingContentWarning Component #13813

Merged
merged 29 commits into from
Oct 30, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Oct 17, 2024

Description

This component is a simple alert message that will be used in #13682.
It shows a warning that the specified subformlayoutset is not configured and a button to navigate to the subformlayout.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 17, 2024
@Jondyr Jondyr changed the title Add SubFormMissingContentWarning Component Feat(subform): Add SubFormMissingContentWarning Component Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (06fb2ef) to head (7e20b2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eNewSubformLayoutSet/CreateNewSubformLayoutSet.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13813   +/-   ##
=======================================
  Coverage   95.15%   95.16%           
=======================================
  Files        1688     1690    +2     
  Lines       22325    22354   +29     
  Branches     2620     2622    +2     
=======================================
+ Hits        21244    21273   +29     
  Misses        835      835           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr force-pushed the 10-17-add_subformmissingcontentwarning_component branch from fe941cb to ba4d06a Compare October 17, 2024 13:11
@Jondyr Jondyr changed the base branch from 10-17-chore_add_studioalert_component to 13476-support-full-config-subform-component October 17, 2024 13:11
Base automatically changed from 13476-support-full-config-subform-component to main October 18, 2024 10:18
@Jondyr Jondyr changed the title Feat(subform): Add SubFormMissingContentWarning Component feat(subform): Add SubFormMissingContentWarning Component Oct 21, 2024
@Jondyr Jondyr changed the base branch from main to 10-17-chore_add_studioalert_component October 21, 2024 10:38
@Jondyr Jondyr marked this pull request as ready for review October 21, 2024 10:39
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good🙂

Co-authored-by: JamalAlabdullah <90609090+JamalAlabdullah@users.noreply.github.com>
Base automatically changed from 10-17-chore_add_studioalert_component to main October 30, 2024 08:21
An error occurred while trying to automatically change base from 10-17-chore_add_studioalert_component to main October 30, 2024 08:21
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev - works as expected :)

@lassopicasso lassopicasso merged commit 951d041 into main Oct 30, 2024
9 checks passed
@lassopicasso lassopicasso deleted the 10-17-add_subformmissingcontentwarning_component branch October 30, 2024 13:37
@lassopicasso lassopicasso removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants