Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add StudioList component #13819

Merged
merged 1 commit into from
Oct 20, 2024
Merged

feat: Add StudioList component #13819

merged 1 commit into from
Oct 20, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Oct 18, 2024

Description

Added new list component based on the List component from The Design System.

Related Issue

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 18, 2024
@TomasEng TomasEng changed the title Add StudioList component feat: Add StudioList component Oct 18, 2024
@TomasEng TomasEng added skip-releasenotes Issues that do not make sense to list in our release notes skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (57f01e1) to head (6c063b1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13819   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files        1635     1638    +3     
  Lines       21828    21842   +14     
  Branches     2567     2567           
=======================================
+ Hits        20796    20810   +14     
  Misses        787      787           
  Partials      245      245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review October 18, 2024 09:48
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@framitdavid framitdavid merged commit 74bf97f into main Oct 20, 2024
14 of 16 checks passed
@framitdavid framitdavid deleted the add-list-component branch October 20, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants