Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete AltinnContentIcon #13893

Merged
merged 2 commits into from
Oct 28, 2024
Merged

chore: delete AltinnContentIcon #13893

merged 2 commits into from
Oct 28, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 23, 2024

Description

  • Deleting unused Icon component

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Oct 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (4fe7cca) to head (092b78e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/components/molecules/AltinnContentLoader.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13893      +/-   ##
==========================================
+ Coverage   95.12%   95.13%   +0.01%     
==========================================
  Files        1674     1673       -1     
  Lines       22195    22189       -6     
  Branches     2610     2608       -2     
==========================================
- Hits        21112    21109       -3     
+ Misses        835      834       -1     
+ Partials      248      246       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid
Copy link
Collaborator

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.30%. Comparing base (4333644) to head (a920a09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/components/molecules/AltinnContentLoader.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@wrt95 I think we should improve the code-cov when we first touching this component. 😊

@wrt95
Copy link
Contributor Author

wrt95 commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.30%. Comparing base (4333644) to head (a920a09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/components/molecules/AltinnContentLoader.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@wrt95 I think we should improve the code-cov when we first touching this component. 😊

I agree, but this component will be moved in #13857, so I'll fix it in that one when I know how it will look, if that is ok @framitdavid ? 😄

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Oct 25, 2024
@wrt95 wrt95 merged commit 4f52f21 into main Oct 28, 2024
9 of 10 checks passed
@wrt95 wrt95 deleted the 13851-delete-AltinnContentIcon branch October 28, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete AltinnContentIcon.tsx
2 participants