Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subform): tablecolumns config design update #13902

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Oct 24, 2024

Description

  • Selecting a component fills in query and headerContent
  • Added a new mock file that contains a layoutSet for testing subform layoutsets subformLayoutMock.ts

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr linked an issue Oct 24, 2024 that may be closed by this pull request
10 tasks
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 24, 2024
@Jondyr Jondyr changed the title feat: tablecolumns config design update feat(subform): tablecolumns config design update Oct 24, 2024
@Jondyr Jondyr added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain2 labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.14%. Comparing base (1deff1c) to head (e337aa4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...umnElement/EditColumnElement/EditColumnElement.tsx 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13902   +/-   ##
=======================================
  Coverage   95.13%   95.14%           
=======================================
  Files        1677     1679    +2     
  Lines       22238    22273   +35     
  Branches     2612     2613    +1     
=======================================
+ Hits        21157    21192   +35     
+ Misses        835      834    -1     
- Partials      246      247    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr force-pushed the 13683-update-subform-tablecolumns-config-to-comply-with-ux-design branch from 0fc3cfc to ee66cc8 Compare October 24, 2024 10:39
@Jondyr Jondyr marked this pull request as ready for review October 28, 2024 08:09
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good jobb and it works perfect ❤️ I have just small comments 😊

@JamalAlabdullah
Copy link
Contributor

I wonder also if we can move the entir card to be in the centar :
image

@Jondyr
Copy link
Member Author

Jondyr commented Oct 29, 2024

I wonder also if we can move the entir card to be in the centar : image

Good catch, i will adjust this 👍

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update subForm tableColumns config to comply with UX design
2 participants