chore: Refactor RedirectBox to StudioRedirectBox #13908
Open
+71
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/process
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13908 +/- ##
==========================================
- Coverage 95.13% 95.13% -0.01%
==========================================
Files 1677 1677
Lines 22238 22236 -2
Branches 2612 2612
==========================================
- Hits 21157 21155 -2
Misses 835 835
Partials 246 246 ☔ View full report in Codecov by Sentry. |
framitdavid
reviewed
Oct 25, 2024
| title, | ||
| children, | ||
| className: givenClassName, | ||
| }: RedirectBoxProps): React.ReactElement => { | ||
| }: StudioRedirectBoxProps): ReactElement => { | ||
| const className = cn(classes.wrapper, givenClassName); |
There was a problem hiding this comment.
Should we use HTMLAttributes here? To ensure we stay consistent? Then we can need our "className" prop.
framitdavid
reviewed
Oct 25, 2024
| children: <div />, | ||
| }; | ||
|
|
||
| describe('StudioRedirectBox', () => { |
There was a problem hiding this comment.
Ref. previous comment, then we can check that className is applied to root by using the test-utils for that. 😊
framitdavid
requested changes
Oct 25, 2024
framitdavid
added
team/studio-core
skip-releasenotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<RedirectBox />to<StudioRedirectBox />Related Issue(s)
RedirectBoxto@studio/components#13859Verification