Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): add hook to scope local and session storage by org and app #13937

Merged
merged 18 commits into from
Oct 29, 2024

Conversation

framitdavid
Copy link
Collaborator

@framitdavid framitdavid commented Oct 29, 2024

Description

This PR introduces Part 2 of scoping storage by consolidating localStorage and sessionStorage into a single reusable hook, useOrgAppScopedStorage. The hook utilizes org and app as a unique storage key to organize data as key-value pairs, providing a cleaner and more manageable structure.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates frontend labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (d76a686) to head (dc28b90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13937   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files        1673     1674    +1     
  Lines       22191    22203   +12     
  Branches     2609     2610    +1     
=======================================
+ Hits        21111    21123   +12     
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid framitdavid changed the title feat(workspace): new storage hook to scope org and app feat(studio-hooks): add hook to scope local and session storage by org and app Oct 29, 2024
@framitdavid framitdavid changed the title feat(studio-hooks): add hook to scope local and session storage by org and app feat(workspace): add hook to scope local and session storage by org and app Oct 29, 2024
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏

@framitdavid framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Oct 29, 2024
@framitdavid framitdavid merged commit 7e13f6b into main Oct 29, 2024
13 of 14 checks passed
@framitdavid framitdavid deleted the feat/resuableOrgAppScopedStoragePart2 branch October 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend kind/dependencies Used for issues or pull requests that are dependency updates skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants