-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workspace): add hook to scope local and session storage by org and app #13937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
kind/dependencies
Used for issues or pull requests that are dependency updates
frontend
labels
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13937 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 1673 1674 +1
Lines 22191 22203 +12
Branches 2609 2610 +1
=======================================
+ Hits 21111 21123 +12
Misses 834 834
Partials 246 246 ☔ View full report in Codecov by Sentry. |
framitdavid
changed the title
feat(workspace): new storage hook to scope org and app
feat(studio-hooks): add hook to scope local and session storage by org and app
Oct 29, 2024
framitdavid
changed the title
feat(studio-hooks): add hook to scope local and session storage by org and app
feat(workspace): add hook to scope local and session storage by org and app
Oct 29, 2024
wrt95
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 👏
framitdavid
added
the
skip-manual-testing
PRs that do not need to be tested manually
label
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
kind/dependencies
Used for issues or pull requests that are dependency updates
skip-manual-testing
PRs that do not need to be tested manually
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Part 2 of scoping storage by consolidating localStorage and sessionStorage into a single reusable hook, useOrgAppScopedStorage. The hook utilizes org and app as a unique storage key to organize data as key-value pairs, providing a cleaner and more manageable structure.
Related Issue(s)
Verification