Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-component): Code list validation #13941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Oct 29, 2024

Description

Added validation for duplicate values on the code list editor. When there are duplidated values,

  • the onChange event is not triggered,
  • the individual input fields containing duplicated values reach native invalid state, with an error message being shown on focus (using the native reportValidity method), and
  • a general error message is diplayed at the bottom.

image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (378bf66) to head (1842427).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13941   +/-   ##
=======================================
  Coverage   95.13%   95.14%           
=======================================
  Files        1676     1678    +2     
  Lines       22232    22261   +29     
  Branches     2612     2617    +5     
=======================================
+ Hits        21151    21180   +29     
  Misses        835      835           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng changed the title Code list validation feat(ui-component): Code list validation Oct 29, 2024
@TomasEng TomasEng force-pushed the code-list-validation branch 4 times, most recently from 682ba5e to e3ed9b7 Compare October 29, 2024 13:03
@TomasEng TomasEng marked this pull request as ready for review October 29, 2024 13:32
@TomasEng TomasEng added skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant team/studio-domain1 labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

1 participant