Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend does not send ?language= for multi patch #2636

Closed
ivarne opened this issue Oct 24, 2024 · 0 comments · Fixed by #2651
Closed

Frontend does not send ?language= for multi patch #2636

ivarne opened this issue Oct 24, 2024 · 0 comments · Fixed by #2651
Assignees
Labels
kind/bug Something isn't working

Comments

@ivarne
Copy link
Member

ivarne commented Oct 24, 2024

Description of the bug

In general I would prefer that all requests send the ?language= GET parameters (ok, maybe not those fetching static files), but at least we need multi patch to work the same way as patch, so that apps that assume language is available for data processing and validation continues to work after upgrading to 8.5.0 with latest frontend.

There has also been a request to include language for instantiation so that it can be used in DataCreation. Consider adding the language parameter to all urls that are instance specific.

Steps To Reproduce

I have not reproduced, but it looks like the language isn't passed to multi patch as it is to the single data element url

const multiPatchUrl = instanceId ? getMultiPatchUrl(instanceId) : undefined;

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: 🧪 Test
Development

Successfully merging a pull request may close this issue.

3 participants