Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested isCompact in Summary2 #2643

Open
3 tasks
adamhaeger opened this issue Oct 24, 2024 · 0 comments
Open
3 tasks

Nested isCompact in Summary2 #2643

adamhaeger opened this issue Oct 24, 2024 · 0 comments
Labels
kind/feature-request New feature or request

Comments

@adamhaeger
Copy link
Contributor

adamhaeger commented Oct 24, 2024

As a Service Owner I want to be able to customize what components will be shown as compact.

Context

Today we support setting isCompact like this:

{
        "id": "MySummary2ID",
        "type": "Summary2",
        "target": {
          "type": "component",
          "id": "MyComponentID"
        },
        "isCompact": true,
         "overrides": [
           {
             "componentId": "MyComponentID",
             "displayType": "list"
           },
 {
             "componentId": "MyComponentID2",
             "displayType": "string"
           }
         ],
}

This will set isCompact to the whole summary.
There is a need also be able to set isCompact for individual components, or exclkude isCompact for certian components.

We therefore suggest implementing isCompact in overrides like this:

{
        "id": "MySummary2ID",
        "type": "Summary2",
        "target": {
          "type": "component",
          "id": "MyComponentID"
        },
        "isCompact": true,
         "overrides": [
           {
             "componentId": "MyComponentID",
             "displayType": "list",
              "isCompact": false,
           },
           {
             "componentId": "MyComponentID2",
             "displayType": "string"
           }
         ],
}

In this case, the override will supersede the component isCompact.

This means you could also set isCompact for a single component only:

{
        "id": "MySummary2ID",
        "type": "Summary2",
        "target": {
          "type": "component",
          "id": "MyComponentID"
        }
         "overrides": [
           {
             "componentId": "MyComponentID",
             "displayType": "list",
"isCompact": true,
           },
 {
             "componentId": "MyComponentID2",
             "displayType": "string"
           }
         ],
}

Acceptance critereas

  • Possible to set isCompact in overrides
  • isCompact in override supersedes isCompact in component
  • isCompact in component allows setting isCompact for individual components
@adamhaeger adamhaeger added kind/feature-request New feature or request and removed status/triage labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant