-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* MinVer update adamralph/minver#839 MinVerDefaultPreReleasePhase -> MinVerDefaultPreReleaseIdentifiers * Don't warn for [Obsolete] api usage or missing XML doc in test projects * Enable nullable in options controller The `[FromQuery]` `?language=` parameter was optional without nullable reference types, but now became required causing a `BadRequest` in tests. It was not decorated as nullable, so a quick fix is to supply a default value of "nb". Other potential resolutions would be * Update the interface so that language is declared nullable for IAppOptionsProvider * Change the public app API, so that language becomes a required get parameter. * Fix all the easy nullability warnings in Controllers Note that enabeling nullable on controllers makes non nullable parameters required and causes additional BadRequest responses * Change behaviour of SecretsLocalClient to throw exception like the client backed by KeyVault * Fix nullability warnings in MulipartRequestReader * Update sonarColud comment * Declare DataController with [ApiController] to automatically trigger bad request Also add test
- Loading branch information
Showing
28 changed files
with
272 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.