Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill logs error when trying to prefill data not appliccable to user #302

Open
tjololo opened this issue Sep 7, 2023 · 0 comments
Open
Labels
kind/bug Something isn't working org/srf Issues relevant for Statens Sivilrettsforvaltning status/triage

Comments

@tjololo
Copy link
Member

tjololo commented Sep 7, 2023

Description of the bug

Applications may be used for both organisations and people and need to supply prefill for both types of users.
Currently if a person tries to start an instance of an app where some fields are prefilled from ER prefill will log the absence of an organisation as an Error. The same happens if a oraganisation starts an instance of an app with prefill from DSF.

For an app used for both organisations and people with prefill from ER and DSF, to cover both users, all traces will contain a error log from Prefill with either the error Could not prefill from DSF, person is not defined or Could not prefill from ER, organisation is not defined.

The only way currently to avoid these is to turn off all error logs from prefill. This could potentially hide other errors during prefill and leave the logs lacking vital information when investigating an error.

We should consider if the error messages mentioned above should be changed to warnings making it possible to filter them out and still keep the error logs.

Steps To Reproduce

  1. Create an app that prefill both DSF and ER information
  2. Start a new instance as a person, and as an organisation
  3. Inspect the logs and see error log statements for both cases even though they bot are OK

Additional Information

No response

@tjololo tjololo added kind/bug Something isn't working status/triage org/srf Issues relevant for Statens Sivilrettsforvaltning labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working org/srf Issues relevant for Statens Sivilrettsforvaltning status/triage
Projects
Status: No status
Development

No branches or pull requests

1 participant