Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationMetadata in app-lib should allow unmapped properties on root level #322

Closed
tjololo opened this issue Oct 13, 2023 · 0 comments
Closed
Assignees
Labels
kind/feature-request New feature or request

Comments

@tjololo
Copy link
Member

tjololo commented Oct 13, 2023

Description

ApplicationMetadata holds configuration for frontend, backend and storage. To add frontend only configuration we need to update app-lib and force developers to update the nuget to expose the new configurations to frontend.
As a first step in making this json config easier to extend with configurations that only is necessary for frontend backend should not remove fields in the root object that is not explicitly mapped in the strongly typed C# model

Additional Information

No response

@tjololo tjololo self-assigned this Oct 13, 2023
tjololo added a commit that referenced this issue Oct 17, 2023
* Deserializing applicationmetadata with unknown root elements puts elements in jsonextensiondata dictionary

* Fix codeql and sonar warnings

* removed newtonsoft jsonextensiondata and added round trip test

* Add WebApplicationFactoryTest that (#324)

This is to ensure that the returned json actually includes the extra fields

---------

Co-authored-by: Ivar Nesje <ivarne@users.noreply.github.com>
@tjololo tjololo closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant