Introduce new option for default selected pages per row #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjololo
added
the
feature
Magnusrm
approved these changes
Jul 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
tjololo
added a commit
that referenced
this pull request
Aug 8, 2023
* Remove trailing slash from source filter in event subscription. (#242) Co-authored-by: Ronny Birkeli <ronny.birkeli@digdir.no> * Fix unauthorized submit resulting in 500 (#243) * catch PlatformException and return 403 * remove code smell * add test for 403 case * add test that other PlatformHttpExceptions are rethrown * return ok inside try block * chore(deps): update nuget non-major dependencies (#251) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Support for extended file analysis (#229) Co-authored-by: Ronny Birkeli <ronny.birkeli@digdir.no> * chore(deps): update dependency coverlet.collector to v6 (#252) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Documentation of parameteres used when generating codelists (#259) Co-authored-by: Ronny Birkeli <ronny.birkeli@digdir.no> * chore(deps): update nuget non-major dependencies (#254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jwtcookieauthentication to v3 (#258) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update nuget non-major dependencies (#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ronny Birkeli <ronny.birkeli@gmail.com> * Feat/add instance selection options to appmetadata (#271) * Add instance selection option to appmetadata * update test to use new OnEntry class * Fix obsolete method in IAppResources * newlines cleanup --------- Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com> * Add defaultRowsPerPage option to InstanceSelection (#272) * add defaultRowsPerPage option to InstanceSelection * remove pagination class * chore(deps): update nuget non-major dependencies (#274) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Mark onEntry as nullable and add check for null (#279) * Introduce new option for default selected pages per row (#280) * Introduce new option for default selected pages per row * fix codesmells * chore(deps): update nuget non-major dependencies (#281) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fixed missing await statement (#282) * Fixed missing await statement * Changed from array to string --------- Co-authored-by: Ronny Birkeli <ronny.birkeli@digdir.no> * Fix bug in 7.13.0 where anonymous statlessapps does not allow anonymous users even if configured (#283) * Sync backend expression functions with frontend (#277) * Implement missing functions in backend * add some testcases for functions that should be evaluated before implemented in the backend code * Simplify some functions * last sync changes from main * update some testfiles * fix some codesmells --------- Co-authored-by: Ronny Birkeli <ronny.birkeli@gmail.com> Co-authored-by: Ronny Birkeli <ronny.birkeli@digdir.no> Co-authored-by: Magnus Revheim Martinsen <mrmartinsen.96@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During testing name of the property defaultRowsPerPage felt misleading as it selects an index from the rowsPerPageOptions list.
Added new config element with the name defaultSelectedOption, this will read the old config if the old is configured and the new is null. Otherwise it will always return the value of the new configoption.
Related Issue(s)
Verification
Documentation