Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return source in validation issues #289

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Return source in validation issues #289

merged 1 commit into from
Aug 30, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Aug 16, 2023 •
edited
Loading

Description

This adds the source field to the validations returned by required validation and modelstate validation so it can be filtered out in app-frontend.

Any other sources that should be added?

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@bjosttveit bjosttveit mentioned this pull request Aug 16, 2023
Merged
21 tasks
@bjosttveit bjosttveit marked this pull request as draft August 16, 2023 13:43
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@bjosttveit bjosttveit marked this pull request as ready for review August 17, 2023 07:31
@bjosttveit bjosttveit added the bugfix Label Pull requests with bugfix. Used when generation releasenotes label Aug 17, 2023
tjololo
tjololo approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@bjosttveit bjosttveit merged commit a77266b into main Aug 30, 2023
12 checks passed
@bjosttveit bjosttveit deleted the validation-issue-source branch August 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

@RonnyB71 RonnyB71 Awaiting requested review from RonnyB71

Assignees
No one assigned
Labels
bugfix Label Pull requests with bugfix. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Source to ValidationIssue
2 participants
@bjosttveit @tjololo