Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CustomLogo): Add field in for custom logo in applicationmetadata #293

Merged
merged 1 commit into from
Aug 24, 2023
Merged

feat(CustomLogo): Add field in for custom logo in applicationmetadata #293

merged 1 commit into from
Aug 24, 2023

Conversation

mikaelrss
Copy link
Contributor

@mikaelrss mikaelrss commented Aug 24, 2023 •
edited
Loading

Description

Adds a new field to ApplicationMetadata which can be used to specify that an app should use a custom Logo.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mikaelrss mikaelrss requested a review from tjololo August 24, 2023 07:58
@mikaelrss
Copy link
Contributor Author

Unsure if an addition like this typically would add some kind of test. Please let me know if I should add some tests to this.

tjololo
tjololo approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@mikaelrss mikaelrss merged commit 9d441d6 into Altinn:main Aug 24, 2023
8 checks passed
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

Assignees
No one assigned
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelrss @tjololo