Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore hidden rows on submit #317

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Ignore hidden rows on submit #317

merged 2 commits into from
Sep 26, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Sep 26, 2023 •
edited
Loading

Description

Revert breaking change where hidden rows are deleted on submit.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

tjololo
tjololo approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@bjosttveit bjosttveit merged commit 1aabc07 into main Sep 26, 2023
10 checks passed
@bjosttveit bjosttveit deleted the ignore-hidden-rows-submit branch September 26, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjololo tjololo tjololo approved these changes

@olemartinorg olemartinorg Awaiting requested review from olemartinorg

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjosttveit @tjololo