Remove static feature flags #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjosttveit
added
the
breaking-change
|
We should hold this PR back until we decide if it is necessary to make v4 of frontend mandatory for using v8 of app-lib |
Yes |
|
As we plan to support v3 of frontend with v8 I close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
footerandprocessActionsfeature flags are static and only exist to make app-frontend backwards compatible with older versions of app-lib. app-frontend v4 will assume that these features are available and will no longer check for these flags since: Altinn/app-frontend-react#1450 and Altinn/app-frontend-react#1516.Assuming that v8 app-lib will require v4 app-frontend these flags can be removed.