Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static feature flags #318

Closed
wants to merge 1 commit into from
Closed

Conversation

bjosttveit
Copy link
Member

Description

The footer and processActions feature flags are static and only exist to make app-frontend backwards compatible with older versions of app-lib. app-frontend v4 will assume that these features are available and will no longer check for these flags since: Altinn/app-frontend-react#1450 and Altinn/app-frontend-react#1516.

Assuming that v8 app-lib will require v4 app-frontend these flags can be removed.

@bjosttveit bjosttveit self-assigned this Sep 28, 2023
@bjosttveit bjosttveit added the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Sep 28, 2023
@tjololo
Copy link
Member

tjololo commented Oct 4, 2023

We should hold this PR back until we decide if it is necessary to make v4 of frontend mandatory for using v8 of app-lib

@bjosttveit
Copy link
Member Author

We should hold this PR back until we decide if it is necessary to make v4 of frontend mandatory for using v8 of app-lib

Yes

@bjosttveit bjosttveit marked this pull request as draft October 4, 2023 08:24
@tjololo
Copy link
Member

tjololo commented Dec 15, 2023

As we plan to support v3 of frontend with v8 I close this PR

@tjololo tjololo closed this Dec 15, 2023
@ivarne ivarne deleted the remove-static-feature-flags branch October 10, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants