Fix more warnings

src/Altinn.App.Api/Altinn.App.Api.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk.Web">
+<Project Sdk="Microsoft.NET.Sdk.Web">
 
   <PropertyGroup>
     <TargetFrameworks>net6.0</TargetFrameworks>
@@ -13,7 +13,7 @@
     <RepositoryType>git</RepositoryType>
     <RepositoryUrl>https://github.com/Altinn/app-lib-dotnet</RepositoryUrl>
     <IsPackable>true</IsPackable>
-    <ImplicitUsings>true</ImplicitUsings>
+    <ImplicitUsings>enable</ImplicitUsings>
 
     <!-- SonarCloud requires a ProjectGuid to separate projects. -->
     <ProjectGuid>{E8F29FE8-6B62-41F1-A08C-2A318DD08BB4}</ProjectGuid>

src/Altinn.App.Api/Controllers/PagesController.cs

@@ -31,8 +31,8 @@ public class PagesController : ControllerBase
         /// <param name="pageOrder">The page order service</param>
         public PagesController(
             IAppModel appModel,
-            IAppResources resources, 
-            IPageOrder pageOrder, 
+            IAppResources resources,
+            IPageOrder pageOrder,
             ILogger<PagesController> logger)
         {
             _appModel = appModel;

src/Altinn.App.Api/Helpers/StartupHelper.cs

@@ -43,6 +43,6 @@ public static string GetApplicationId()
     {
         string appMetaDataString = File.ReadAllText("config/applicationmetadata.json");
         JObject appMetadataJObject = JObject.Parse(appMetaDataString);
-        return appMetadataJObject.SelectToken("id").Value<string>();
+        return appMetadataJObject.SelectToken("id")?.Value<string>() ?? throw new Exception("config/applicationmetadata.json does not contain an \"id\" property");
     }
 }

test/Altinn.App.Api.Tests/Controllers/ValidateControllerValidateDataTests.cs

@@ -9,6 +9,7 @@
 using Altinn.App.Core.Models.Validation;
 using Altinn.Platform.Storage.Interface.Models;
 using Microsoft.AspNetCore.Mvc;
+using FluentAssertions;
 using Moq;
 using Xunit;
 
@@ -221,7 +222,7 @@ public async Task TestValidateData(ValidateDataTestScenario testScenario)
         {
             var result = await validateController.ValidateData(org, app, instanceOwnerId, testScenario.InstanceId,
                 testScenario.DataGuid);
-            Assert.IsType(testScenario.ExpectedResult, result);
+            result.Should().BeOfType(testScenario.ExpectedResult);
         }
         else
         {

test/Altinn.App.Api.Tests/Mocks/Authentication/JwtCookiePostConfigureOptionsStub.cs

@@ -14,7 +14,7 @@ namespace Altinn.App.Api.Tests.Mocks.Authentication
     public class JwtCookiePostConfigureOptionsStub : IPostConfigureOptions<JwtCookieOptions>
     {
         /// <inheritdoc />
-        public void PostConfigure(string name, JwtCookieOptions options)
+        public void PostConfigure(string? name, JwtCookieOptions options)
         {
             if (string.IsNullOrEmpty(options.JwtCookieName))
             {

test/Altinn.App.Api.Tests/Mocks/PepWithPDPAuthorizationMockSI.cs

@@ -61,7 +61,7 @@ public async Task<XacmlJsonResponse> GetDecisionForRequest(XacmlJsonRequestRoot
             }
             catch
             {
-                return null;
+                return null!;
             }
         }