Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New field AltinnNugetVersion in applicationMetadata.cs #333

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 2, 2023

Rather simple implementation that makes it possible to override, but if the property isn't set, the version info will be read by from the assembly that contains ApplicationMetadata.

Should probably consider adding some error handling, but I don't know when it might trigger, so it's hard to know what to say.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne ivarne force-pushed the nuget_version_in_app_metadata branch from 89d0e1a to a419b8b Compare November 2, 2023 13:12
@ivarne ivarne added this to the 8.0.0 milestone Nov 6, 2023
@ivarne ivarne force-pushed the nuget_version_in_app_metadata branch from a419b8b to 2df7b87 Compare November 13, 2023 14:17
@ivarne
Copy link
Member Author

ivarne commented Nov 13, 2023

@tjololo This was updated to use a different version that doesn't include prerelease version info.

Previous: 8.0.0-preview.10.3+9c4ed1a127458a23d522f4398a591f5434fae0fd

Now: 8.0.0.0

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ivarne ivarne merged commit 58862ae into v8 Nov 13, 2023
10 checks passed
@ivarne ivarne deleted the nuget_version_in_app_metadata branch November 13, 2023 14:25
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants