Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V7] Add [Authorize] attribute on AuthorizationController.GetCurrentParty #339

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 6, 2023

This means that the code won't crash with missing cookie when the cookie exipires

Opening this for main / v7 in case we want to release a fixed nuget version, to reduce 500 errors caused by expired cookies.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

This means that the code won't crash with missing cookie when the cookie
exipires
@ivarne ivarne changed the title Add [Authorize] attribute on AuthorizationController.GetCurrentParty [V7] Add [Authorize] attribute on AuthorizationController.GetCurrentParty Nov 6, 2023
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivarne ivarne requested a review from tjololo November 13, 2023 09:24
@ivarne ivarne merged commit 267c2ef into main Nov 15, 2023
10 checks passed
@ivarne ivarne deleted the ivarne/authorize_getCurrentParty-v7 branch November 15, 2023 10:23
ivarne added a commit that referenced this pull request Jan 26, 2024
* chore(deps): update nuget non-major dependencies (#310)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add [Authorize] attribute on AuthorizationController.GetCurrentParty (#339)

This means that the code won't crash with missing cookie when the cookie
exipires

* chore(deps): update nuget non-major dependencies (#330)

* chore(deps): update nuget non-major dependencies

* Fix broken test

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>

* chore(deps): update dependency moq to v4.20.70 (#371)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/setup-java action to v4 (#372)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update nuget non-major dependencies (#385)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update github/codeql-action action to v3 (#388)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/setup-dotnet action to v4 (#386)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact action to v4 (#387)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Support using connectionString for ApplicationInsights (#379) (#391)

This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560

* chore(deps): update nuget non-major dependencies (#390)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* v7: Fix issue with non-ascii characters in code list parameters not being correctly encoded in parameter header. (#402)

Likely fix Altinn/codelists-lib-dotnet#23

* Include changes from main in v8 branch

mostly verion updates

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PlatformServices UserHelper.GetUserContext can call Profile with invalid userid
2 participants