Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using connectionString for ApplicationInsights #379

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Dec 13, 2023

This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560
@ivarne ivarne marked this pull request as ready for review December 13, 2023 14:20
@ivarne ivarne requested a review from tjololo December 13, 2023 14:20
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

33.3% Coverage on New Code (required ≥ 65%)
40.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should probably also make this changefor v7 as well.

@ivarne ivarne merged commit 97da907 into v8 Dec 29, 2023
10 of 11 checks passed
@ivarne ivarne deleted the ivarne/appInsights-connectionString branch December 29, 2023 20:53
ivarne added a commit that referenced this pull request Dec 29, 2023
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560
tjololo pushed a commit that referenced this pull request Jan 9, 2024
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560
ivarne added a commit that referenced this pull request Jan 26, 2024
* chore(deps): update nuget non-major dependencies (#310)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add [Authorize] attribute on AuthorizationController.GetCurrentParty (#339)

This means that the code won't crash with missing cookie when the cookie
exipires

* chore(deps): update nuget non-major dependencies (#330)

* chore(deps): update nuget non-major dependencies

* Fix broken test

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>

* chore(deps): update dependency moq to v4.20.70 (#371)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/setup-java action to v4 (#372)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update nuget non-major dependencies (#385)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update github/codeql-action action to v3 (#388)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/setup-dotnet action to v4 (#386)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/upload-artifact action to v4 (#387)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Support using connectionString for ApplicationInsights (#379) (#391)

This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.

microsoft/ApplicationInsights-dotnet#2560

* chore(deps): update nuget non-major dependencies (#390)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* v7: Fix issue with non-ascii characters in code list parameters not being correctly encoded in parameter header. (#402)

Likely fix Altinn/codelists-lib-dotnet#23

* Include changes from main in v8 branch

mostly verion updates

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>
@tjololo tjololo added the feature Label Pull requests with new features. Used when generation releasenotes label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application Insights will require connection string (instead of instrumentation key) in 2025
2 participants