-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using connectionString for ApplicationInsights #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps. microsoft/ApplicationInsights-dotnet#2560
Quality Gate failedFailed conditions 33.3% Coverage on New Code (required ≥ 65%) |
Closed
2 tasks
tjololo
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We should probably also make this changefor v7 as well.
ivarne
added a commit
that referenced
this pull request
Dec 29, 2023
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps. microsoft/ApplicationInsights-dotnet#2560
5 tasks
tjololo
pushed a commit
that referenced
this pull request
Jan 9, 2024
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps. microsoft/ApplicationInsights-dotnet#2560
ivarne
added a commit
that referenced
this pull request
Jan 26, 2024
* chore(deps): update nuget non-major dependencies (#310) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add [Authorize] attribute on AuthorizationController.GetCurrentParty (#339) This means that the code won't crash with missing cookie when the cookie exipires * chore(deps): update nuget non-major dependencies (#330) * chore(deps): update nuget non-major dependencies * Fix broken test --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com> * chore(deps): update dependency moq to v4.20.70 (#371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-java action to v4 (#372) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update nuget non-major dependencies (#385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github/codeql-action action to v3 (#388) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/setup-dotnet action to v4 (#386) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/upload-artifact action to v4 (#387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Support using connectionString for ApplicationInsights (#379) (#391) This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps. microsoft/ApplicationInsights-dotnet#2560 * chore(deps): update nuget non-major dependencies (#390) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * v7: Fix issue with non-ascii characters in code list parameters not being correctly encoded in parameter header. (#402) Likely fix Altinn/codelists-lib-dotnet#23 * Include changes from main in v8 branch mostly verion updates --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Vemund Gaukstad <tjololo@users.noreply.github.com>
tjololo
added
the
feature
Label Pull requests with new features. Used when generation releasenotes
label
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wil become a requirement from may 2025, so adding this early ensures that does not become an requirement for updating apps.
microsoft/ApplicationInsights-dotnet#2560
Description
Related Issue(s)
Verification
Documentation