New validation interfaces to support incremental validation on multiple data models #701
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _logger.LogError( | ||
| "Could not determine if {dataType} requires app logic for application {org}/{app}", | ||
| dataType, | ||
| org, |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| e, | ||
| "Error while running validator {validatorName} for task {taskId} on instance {instanceId}", | ||
| v.ValidationSource, | ||
| taskId, |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| "Error while running validator {validatorName} for task {taskId} on instance {instanceId}", | ||
| v.ValidationSource, | ||
| taskId, | ||
| instance.Id |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| e, | ||
| "Error while running validator {validatorName} on task {taskId} in instance {instanceId}", | ||
| validator.GetType().Name, | ||
| taskId, |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| "Error while running validator {validatorName} on task {taskId} in instance {instanceId}", | ||
| validator.GetType().Name, | ||
| taskId, | ||
| instance.Id |
Check failure
Code scanning / CodeQL
Log entries created from user input High
| "Could not determine if {dataType} requires app logic for application {org}/{app}", | ||
| dataType, | ||
| org, | ||
| app |
Check failure
Code scanning / CodeQL
Log entries created from user input High
src/Altinn.App.Core/Features/Validation/Wrappers/FormDataValidatorWrapper.cs
Dismissed
Show dismissed
Hide dismissed
src/Altinn.App.Core/Features/Validation/Wrappers/FormDataValidatorWrapper.cs
Fixed
Show fixed
Hide fixed
src/Altinn.App.Core/Features/Validation/Wrappers/DataElementValidatorWrapper.cs
Fixed
Show fixed
Hide fixed
| CachedInstanceDataAccessor dataAccessor = new CachedInstanceDataAccessor( | ||
| instance, | ||
| _dataClient, | ||
| _appMetadata, | ||
| _appModel | ||
| ); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
* new interface IValidator to rule them all * Incremental validation is now a separate interface * Try to add compatibility
ivarne
force-pushed
the
feat/ivarne/full-incrmental-validation
branch
from
75b75ce
to
657efd6
Compare
src/Altinn.App.Core/Features/Validation/Wrappers/DataElementValidatorWrapper.cs
Dismissed
Show dismissed
Hide dismissed
src/Altinn.App.Core/Features/Validation/Wrappers/FormDataValidatorWrapper.cs
Dismissed
Show dismissed
Hide dismissed
|
The previous three validation interfaces
ITaskValidator,IDataElementValidatorandIFormDataValidatorwhere only the formData variant supported incremental validationHasRelevantChangesdoes not work properly in a world where validation depends on the data from multiple data models. The hardest issue to solve was that our standard validators would run multiple times for different data elements, and the only way to fix that was to write aITaskValidatorbut that would not support incremental validation.The proposed solution here is to abandon the concepts of validating single data elements individually, but only ever validate everything on a single task (possibly incrementally by only running a subset of the validators selected by
HasRelevantChanges). I also add aIInstanceDataAccessorto allow validators to access the content of data elements in a way so that fetches are shared between validators and we ensure that the updated data is used in aPATCHrequest.This caused the addition of a
IValidatorinterface with compatibility implementations for the older interfacesPS In addition I marked
ValidationIssue.Sourceobsolete, and createdValidationIssueWithSourceinstead. The source parameter is set by theValidationServiceanyway, so it makes sense to hide it for app developers so that they don't think about what value to give.Related Issue(s)
Likely remaining work
Altinn.App.Core.Features.Validation.Defaultto implementIValidatorinstead of relying on the compatibility layersVerification
Documentation