Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation of LocalTest.Services.Storage.Implementation #4

Open
HenningNormann opened this issue Aug 23, 2021 · 4 comments
Labels
kind/feature-request New feature or request

Comments

@HenningNormann
Copy link
Contributor

HenningNormann commented Aug 23, 2021

Is your feature request related to a problem? Please describe

In OED we need to look up instances. Most of the methods in LocalTest.Services.Storage.Implementation are not implemented (throws NotImplementedException) - including all methods to search for instances.

Another problem is that the HomeController.GetTestOrgToken doesn't support setting read/write scopes need use APIs above.

Describe the solution you'd like

Implement the not implemented methods mentioned above, and add support for setting read/write scopes in GetTestOrgToken.

Describe alternatives you've considered

Additional context

@altinnadmin
Copy link
Member

Will be handled by Altinn/altinn-storage#127, see first "main problem".

@acn-sbuad
Copy link
Contributor

@altinnadmin It would be a quick win to implement the missing methods. I don't think this should be put on hold because of future support of multiple Storage backends.
@HenningNormann a seperate issue should be created for the issues with scopes in localtest so they can be prioritized individually.

@altinnadmin
Copy link
Member

@acn-sbuad Are you sure? If what Henning is writing is correct, it is most methods?

Most of the methods in LocalTest.Services.Storage.Implementation are not implemented (throws NotImplementedException) - including all methods to search for instances.

@SandGrainOne
Copy link
Member

I created an issue covering one of the methods some time ago: #30

@mijohansen mijohansen transferred this issue from Altinn/altinn-studio Feb 6, 2023
@nkylstad nkylstad removed this from Team Studio Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants