-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Amino.NET 1.5.2 #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ # ] Some functions no longer throw an exception based on an Exception [ # ] More anonymous types have been removed [ # ] Adapted more functions to work with inline if expressions [ # ] Fixed code formatting
[ - ] Removed all Try Catch statements that would just repeat exceptions anyways [ # ] Fixed formatting
Structure/refactor code
[ # ] SubClient.post_blog now accepts IEnumerable<byte[]> instead of List type [ # ] SubClient.post_wiki now accepts IEnumerable<byte[]> instead of List type [ # ] SubClient.edit_blog now accepts IEnumerable<byte[]> instead of List type [ + ] Added ability to pass Links into Client.upload_media(string), this allows people to pass custom media URLs into Amino Media
[ + ] Added Client.get_blog_info(string) [ + ] Added Client.get_wiki_info(string) [ + ] Added Client.get_message_info(string,string)
[ + ] Added Client.register_google(string, string, string, string) [ # ] Client.register() should no longer throw invalid request
Feature/add more functions
[ # ] Fixed Client.register() throwing invalid request due to newtonsoft JSON [ # ] Fixed typo in Types class [ + ] Added start of builder class
[ # ] Changed PostBuilder.MediaList from Dictionary<byte[], string> to List<(byte[], string?, string?)> [ + ] Added PostBuilder.BackgroundImage [ + ] Added PostBuilder.BackgroundColor [ + ] Added PostBuilder.BackgroundType [ + ] Added PostBuilder.FansOnly [ + ] Added PostBuilder.WithBackgroundImage(byte[]) [ + ] Added PostBuilder.WithBackgroundImage(string) [ # ] Adjusted functions to handle new parameters like caption and mediaKey [ + ] Added SubClient.create_post(PostBuilder)
Feature/add builder class
[ # ] Adapted the JSON payload to the hopefully proper format
hopefully fixed send_message
FabioGaming
commented
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge Amino.NET 1.5.2 into main for release