Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake workflow #37

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Add cmake workflow #37

merged 2 commits into from
Jan 4, 2024

Conversation

xakod
Copy link
Contributor

@xakod xakod commented Sep 2, 2023

Introduces cmake workflow

@AmonRaNet AmonRaNet force-pushed the master branch 4 times, most recently from 9fd0787 to 883534d Compare January 3, 2024 22:02
@AmonRaNet
Copy link
Owner

Very good PR :)
Please fix tiny issues in new yaml file (you can check them in pre-commit action):

  • empty line at the end of file is missing
  • file has mix of tabs and spaces - please use only spaces

@AmonRaNet
Copy link
Owner

I can fix it myself, but then it will be under my name. Not ideal

@AmonRaNet
Copy link
Owner

Keep in mind that I have re-based your branch on top of latest master

@AmonRaNet AmonRaNet self-assigned this Jan 3, 2024
@AmonRaNet
Update cmake.yaml
2c3d80b 
- Added include paths
- Fixed pre-commit issues
@AmonRaNet AmonRaNet merged commit 7454ba8 into AmonRaNet:master Jan 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AmonRaNet AmonRaNet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xakod @AmonRaNet