Merge pull request #705 from Amsterdam-Music-Lab/fix/strict-mode

only activate React StrictMode when Docker variable is True
Amsterdam-Music-Lab · Jan 9, 2024 · 58c5b8f · 58c5b8f
2 parents 7279e13 + f687944
commit 58c5b8f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.env.dist b/.env.dist
@@ -27,3 +27,4 @@ REACT_APP_HTML_OG_TITLE=Amsterdam Music Lab Experiment # optional: information f
 REACT_APP_HTML_OG_URL= # optional: information for web crawlers
 REACT_APP_HTML_BODY_CLASS= # optional: assign a css class to the <body> tag in index.html, for custom styling
 REACT_APP_SENTRY_DSN= # optional: link to sentry instance, e.g. https://xxx@xxx.ingest.sentry.io/xxx
+REACT_APP_STRICT= # optional: use StrictMode for development
diff --git a/docker-compose.yaml b/docker-compose.yaml
@@ -81,6 +81,7 @@ services:
           - REACT_APP_HTML_OG_URL=${REACT_APP_HTML_OG_URL}
           - REACT_APP_HTML_BODY_CLASS=${REACT_APP_HTML_BODY_CLASS}
           - REACT_APP_SENTRY_DSN=${REACT_APP_SENTRY_DSN}
+          - REACT_APP_STRICT=${REACT_APP_STRICT}
         ports:
           - 3000:3000
         command: sh -c "yarn scss && yarn start"

diff --git a/frontend/src/index.js b/frontend/src/index.js
@@ -17,7 +17,7 @@ initWebAudioListener();
 const container = document.getElementById("root");
 const root = createRoot(container);
 root.render(
-    process.env.NODE_ENV === "development" ? (
+    process.env.REACT_APP_STRICT === true ? (
         <StrictMode>
             <App />
         </StrictMode>