From ad48b7dd8f45e1d4b5e336b3ebfa63a0bb1af801 Mon Sep 17 00:00:00 2001 From: BeritJanssen Date: Fri, 7 Jun 2024 09:32:56 +0200 Subject: [PATCH] fix: implement review suggestions --- backend/experiment/serializers.py | 2 +- .../ExperimentCollectionDashboard.tsx | 2 +- frontend/src/scss/color-schemes.scss | 4 ---- frontend/src/types/Experiment.ts | 2 +- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/backend/experiment/serializers.py b/backend/experiment/serializers.py index 4f0c29ff7..b710e655d 100644 --- a/backend/experiment/serializers.py +++ b/backend/experiment/serializers.py @@ -67,7 +67,7 @@ def serialize_experiment(experiment_object: Experiment, participant: Participant 'started_session_count': get_started_session_count(experiment_object, participant), 'finished_session_count': get_finished_session_count(experiment_object, participant), 'description': experiment_object.description, - 'image': serialize_image(experiment_object.image) if experiment_object.image else '', + 'image': serialize_image(experiment_object.image) if experiment_object.image else None, } diff --git a/frontend/src/components/ExperimentCollection/ExperimentCollectionDashboard/ExperimentCollectionDashboard.tsx b/frontend/src/components/ExperimentCollection/ExperimentCollectionDashboard/ExperimentCollectionDashboard.tsx index 00b970893..f0fb29271 100644 --- a/frontend/src/components/ExperimentCollection/ExperimentCollectionDashboard/ExperimentCollectionDashboard.tsx +++ b/frontend/src/components/ExperimentCollection/ExperimentCollectionDashboard/ExperimentCollectionDashboard.tsx @@ -37,7 +37,7 @@ export const ExperimentCollectionDashboard: React.FC (
  • - +

    {exp.name}

    {exp.description}

    diff --git a/frontend/src/scss/color-schemes.scss b/frontend/src/scss/color-schemes.scss index 704a53770..0929242af 100644 --- a/frontend/src/scss/color-schemes.scss +++ b/frontend/src/scss/color-schemes.scss @@ -38,10 +38,6 @@ @include btn-style($blue); } } - - .player { - - } } .neutral-inverted { diff --git a/frontend/src/types/Experiment.ts b/frontend/src/types/Experiment.ts index 62f3dc7fe..cb5413a20 100644 --- a/frontend/src/types/Experiment.ts +++ b/frontend/src/types/Experiment.ts @@ -5,7 +5,7 @@ export default interface Experiment { name: string; slug: string; description: string; - image: IImage; + image?: IImage; started_session_count: number; finished_session_count: number; } \ No newline at end of file