fix: do not call onNext() from within map #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some refactoring after all, also making sure that resources aren't loaded double anymore, and that the non-webAudio players load all sections instead of just the first one. I tested this for MatchingPairs, ThatsMySong and DDI / BAT, but more testing (Categorization) is very welcome. |
This was referenced May 7, 2024
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1002 . The problem was caused by the
checkSectionLoadedmechanism, which was introduced to prevent reloading files for consecutive views, such as in SongSync. TheonNextcall in the.maploop would cause the next view to be triggered before all files were loaded, as theOriginalsboard contains duplicates of sections.Moving the
onNext()call to after the.maploop should fix this.