Added: Validate file existence validation in Experiment & Playlist forms #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeritJanssen
reviewed
Jun 3, 2024
BeritJanssen
reviewed
Jun 3, 2024
BeritJanssen
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Nice! The issues I pointed out in experiment.forms will get fixed with merging, just pointing this out in case you want to drop commit 2d02f53 here to clean the history.
The commit adds a new validation method, `file_exists_validator`, to check if the section files referenced in the playlist exist. This validation is performed in the `clean` method of the Playlist model. If any section file is not found, a `ValidationError` is raised and added to the `csv` field errors.
The commit refactors the `clean_csv` method in the Playlist model to perform file existence validation for section files. It iterates over the sections associated with the playlist and checks if the referenced files exist using the `file_exists_validator` function. If any file is not found, a `ValidationError` is raised and added to the `csv` field errors.
… input disappear in add sections
drikusroor
force-pushed
the
enhance/playlist-validation-file-exist
branch
from
64859f7 to
154ead1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the file existence validation in the Playlist model and admin form.
The
clean_csvmethod in the Playlist model now performs file existence validation for section files. It checks if the referenced files exist using thefile_exists_validatorfunction. If any file is not found, aValidationErroris raised and added to thecsvfield errors.Additionally, it fixes an existing problem in the experiment rules validation method.