Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include BASE_URL in image file serialization #1093

Merged
merged 9 commits into from
Jun 11, 2024
Merged

fix: include BASE_URL in image file serialization #1093

merged 9 commits into from
Jun 11, 2024

Conversation

BeritJanssen
Copy link
Collaborator

@BeritJanssen BeritJanssen commented Jun 10, 2024 •
edited
Loading

This branch fixes a problem on the servers, in which image requests are incorrectly prefixed with API_ROOT. Instead, this branch prefixes the BASE_URL for the backend image serialization.

@BeritJanssen BeritJanssen self-assigned this Jun 10, 2024
drikusroor
drikusroor approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@drikusroor drikusroor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BeritJanssen BeritJanssen marked this pull request as draft June 10, 2024 15:00
@BeritJanssen BeritJanssen changed the title fix: optionally include subpath in image file serialization fix: include BASE_URL in image file serialization Jun 10, 2024
@BeritJanssen BeritJanssen marked this pull request as ready for review June 10, 2024 15:44
drikusroor
drikusroor approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@drikusroor drikusroor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did AML_SUBPATH not work well in the end?

backend/aml/base_settings.py Show resolved Hide resolved
backend/experiment/tests/test_views.py Outdated Show resolved Hide resolved
@BeritJanssen BeritJanssen merged commit 38669ad into develop Jun 11, 2024
10 checks passed
@BeritJanssen BeritJanssen deleted the fix/image-path branch June 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drikusroor drikusroor drikusroor approved these changes

Assignees

@BeritJanssen BeritJanssen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeritJanssen @drikusroor